Ian Maxon has posted comments on this change. Change subject: Add Checkpoint Test ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java: Line 149: if (initialLowWaterMarkFileId == currentLowWaterMarkLogFileId) { > Even though there is no checkpoint yet, there is a tiny chance (depending o I see, so it's to assure that it does indeed happen, either by flush or (more likely) by what's in this condition. What about the second part after this then, the next while loop? It would go something like the checkpoint would be done even though it isn't necessary to cause the low water mark to move to the 2nd file, and then the deletion is checked? -- To view, visit https://asterix-gerrit.ics.uci.edu/1270 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
