Murtadha Hubail has posted comments on this change. Change subject: Add Checkpoint Test ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1270/3/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java: Line 139: while (logManager.getLogFileIds().size() == 1) { > Why ==1 and not !=2 here now? Was it getting to 3 somehow and going forever It was indeed going forever but not because of going to 3. It was caused by issue ASTERIXDB-1701. I changed to == 1 while debugging the issue and then decided to keep it like that; !=2 should be fine as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/1270 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
