Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules ......................................................................
Patch Set 2: (2 comments) 2 more comments on patchset 2 - forgot to submit ... https://asterix-gerrit.ics.uci.edu/#/c/1304/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java: Line 43: public static List<Pair<AbstractRuleController, List<IAlgebraicRewriteRule>>> buildLogical() { > I did it this way so I could make these functions static, and thereby able I was thinking that we could reuse them by extending DefaultRuleSetFactory, but this works as well. https://asterix-gerrit.ics.uci.edu/#/c/1304/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java: Line 32: * @throws AlgebricksException > I did this so my implementation could throw an exception. Ok, but why does the construction of rules throw an exception? But assuming that that is needed, I think that we should be consistent and add the same throws clause to the other method as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/1304 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
