Steven Jacobs has posted comments on this change. Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1304/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java: Line 32: * @throws AlgebricksException > Ok, but why does the construction of rules throw an exception? But assuming I guess I could remove it. I'm still highly concerned about not noticing changes to the default ruleset, and this gives the ability to break an extension when things aren't as expected. So should I add it to Physical, or remove it entirely? -- To view, visit https://asterix-gerrit.ics.uci.edu/1304 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
