Ian Maxon has posted comments on this change. Change subject: Fix Upsert Pipeline ......................................................................
Patch Set 3: (4 comments) More questions out of curiosity than anything else :) Overall I am wondering if any of these fixes apply to the equivalent secondary index operator? And also if we need to worry about the order of things possibly being changed from InsertDeleteUpsertOperator affecting other operators inadvertently. https://asterix-gerrit.ics.uci.edu/#/c/1308/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 97: || (filterFieldIndex >= 0 && (fieldPermutation.length > numOfPrimaryKeys + 2))); Why is meta always before filter? Shouldn't meta be set to something like -1 if hasMeta is false? Line 202: } What was happening previously with meta/filter? Line 218: } Is the crux of the fix here that the modCallBack.setOp(Operation.DELETE) got shifted down here? From what I saw what you said, I think it was somehow related to insert overwriting part of the deleted tuple before it could be returned? https://asterix-gerrit.ics.uci.edu/#/c/1308/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java: Line 96: } Why does the order matter here? Is it determining the order of the fields that will come in to the insert/upsert/delete pipeline? -- To view, visit https://asterix-gerrit.ics.uci.edu/1308 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c19d448f9664ecaeac600668a6dbdcf40673c56 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
