Yingyi Bu has posted comments on this change. Change subject: Fix Upsert Pipeline ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1308/2/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java: Line 138: ByteBufferInputStream bbis = new ByteBufferInputStream(); > We are using them when we debug. They are quite useful. ask Till ;) Why can't those printXXX methods be moved to a dedicated Util class, e.g., FrameDebugUtil? It looks that they all can be implemented by calling the public interface methods of the FrameTupleAccessor. In this way, we can keep the FrameTupleAccessor relative clean. -- To view, visit https://asterix-gerrit.ics.uci.edu/1308 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c19d448f9664ecaeac600668a6dbdcf40673c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
