Ian Maxon has posted comments on this change. Change subject: Full-text implementation step 1 ......................................................................
Patch Set 14: (2 comments) Commented on the few SonarQube comments I think are legitimate, some of the others either seem to disagree with the code formatter or don't seem particularly avoidable. https://asterix-gerrit.ics.uci.edu/#/c/1228/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java: Line 58: protected static final int typeIndicatorSize = 1; > MAJOR SonarQube violation: This should be renamed. final static should be in all uppercase with underscores for spaces. https://asterix-gerrit.ics.uci.edu/#/c/1228/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/FullTextContainsDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/FullTextContainsDescriptor.java: Line 42: public static final Map<String, ATypeTag> paramTypeMap = new LinkedHashMap<>(); > CRITICAL SonarQube violation: Why isn't this protected/private? Similar for all the below comments. -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
