Taewoo Kim has posted comments on this change.

Change subject: Full-text implementation step 1
......................................................................


Patch Set 15:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1228/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java:

Line 79:     public static final PointableBinaryComparatorFactory 
UTF8STRING_LOWERCASE_TOKEN_POINTABLE_INSTANCE = new 
PointableBinaryComparatorFactory(
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1228/15/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryTokenizerFactoryProvider.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryTokenizerFactoryProvider.java:

Line 41:     private static final IBinaryTokenizerFactory 
aqlStringNoTypeTagTokenizer = new DelimitedUTF8StringBinaryTokenizerFactory(
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1228/15/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java:

Line 79:     private final IBinaryComparator strLowerCaseTokenCmp = 
AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_TOKEN_POINTABLE_INSTANCE
> MAJOR SonarQube violation:
Done


Line 81:     private final IBinaryComparator strLowerCaseCmp = 
AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_POINTABLE_INSTANCE
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Heri Ramampiaro <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Jianfeng Jia <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to