Michael Blow has posted comments on this change. Change subject: Remove Server Context ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1320/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: Line 186: baseDir = new File(new File(NodeControllerService.class.getName()), id); > it is used for binary deployment. if we want to make it configurable. let's It seems not to add much to the change to add something equivalent to: @Option(name = "-cc-root", usage = "Sets the root folder used for file operations. (default: ClusterControllerService)") public String ccRoot = "ClusterControllerService"; to NCConfig and reference here? -- To view, visit https://asterix-gerrit.ics.uci.edu/1320 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4261cf44410b498e84ffcac5e217281a306a7f03 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
