Yingyi Bu has posted comments on this change. Change subject: Remove Server Context ......................................................................
Patch Set 1: >> too many contexts = confusion. >> not only for existing developers but also for new ones. I don't think they really cause troubles. The stuffs really causing troubles are those that lacks facets and extensibility, for example, AqlMetdataProvider and various storage code. >> and those are wrappers with unused methods. Pls don't think they are "wrappers". Tomorrow you can add x, y, z into a context class and doesn't need to change interface contracts, but you cannot x, y, z into the File class. >> We can't add contexts for potential future use. >> Once we have the need for additional contexts, we can add them. Once the contexts are removed, ClusterControllerService etc will start becoming a kitchen sink like AqlMetadataProvider. >> For the SonarQube argument, show me a place >> where having the ICCContext or the ServerContext >> will get rid of that. I was talking about design principles like facets and separating concerns. For places lacking those, we have many warnings, e.g., AqlMetadataProvider and various storage classes. -- To view, visit https://asterix-gerrit.ics.uci.edu/1320 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4261cf44410b498e84ffcac5e217281a306a7f03 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
