Wail Alkowaileet has posted comments on this change.
Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser
......................................................................
Patch Set 4:
For some reason, I cannot inline my comment.
I will follow this format:
{line# : code
comment}
220 : if (curRecType.isClosedField(curFNames[iter1]))
should that check if it's optional instead of closed. Because a field can be
optional and that allows null.
Probably we can get rid of the first part (213 - 230). And make:
recType = curRecType == null ? ARecordType.FULLY_OPEN_RECORD_TYPE : curRecType;
236 : if (obj.isNull(attrName) || obj.length() == 0)
is obj.length() ever going to equal zero? obj is the parent of attrName.
258: if (writeRecord == true)
no need for == true
Great work.. Thanks!
--
To view, visit https://asterix-gerrit.ics.uci.edu/1339
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Xikui Wang <[email protected]>
Gerrit-HasComments: No
