Xikui Wang has posted comments on this change. Change subject: Fix ASTERIXDB-1609 and OrderedList bug in TweetParser ......................................................................
Patch Set 4: Hi Wail, Thanks for your comments! My replies are as follow: Line 220: Here the incoming data is checked first. If the incoming data doesn't have this attribute, and it's not optional, then it throws exception. For optional attribute, if incoming attribute is null, this check will be false as it's not closed field. Line 213 - 230: Actually it's necessary. I found out if we assigned extra attribute to closed datatype, there will be a problem in inserting. So for the closed datatype, I am using cherry-pick like method, and for open datatype, I just pull whatever in that record. Line 236, Yes. There is. The weird part of Tweets coming in is, there are certain attribute only has name but with content. The length == 0 case is when obj is a JSONArray. Line 258, Fixed. Thanks for your help! -- To view, visit https://asterix-gerrit.ics.uci.edu/1339 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia27148cb10206b93dabf7655aed68f3004f96dfd Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: No
