Till Westmann has posted comments on this change. Change subject: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2999/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS1, Line 728: validateIfResourceIsActiveInFeed Wondering why we are a) dropping the source location and b) only reporting the first listener. PS1, Line 2966: beforeDdlOnDataset This name confused me when I was reading the calls to it. It would have been less confusing if it were called "callBeforeDdlOnDatasetHook", but that's obviously not nice. If you have an idea how to resolve this, please do otherwise just leave it as-is. PS1, Line 2967: appCtx Should we just get the application context from the metadata provider here? -- To view, visit https://asterix-gerrit.ics.uci.edu/2999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38254582e08d97951a949f7327c8c3d7cf2ab51d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
