Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2999/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS1, Line 728: validateIfResourceIsActiveInFeed > Wondering why we are a) dropping the source location and b) only reporting a) I put it back. However, I feel like this should be a runtime data exception and not a compilation exception. We can change it in a different change if you feel the same way. b) Theoretically speaking, a dataset is fed by a single active data source (i.e. a single listener). So, it's one or nothing. PS1, Line 2966: validateDatasetSta > This name confused me when I was reading the calls to it. It would have bee Where I come from, callBeforeXHook is called beforeX :) E.g. callBeforeInsertHook(tuple) = beforeInsert(tuple). However, I changed it to validateDatasetState, is that better? PS1, Line 2967: > Should we just get the application context from the metadata provider here? Done. Even thought I feel like I'm going to question the person who wrote this code. -- To view, visit https://asterix-gerrit.ics.uci.edu/2999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38254582e08d97951a949f7327c8c3d7cf2ab51d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
