Till Westmann has posted comments on this change. Change subject: Supports flexible degree of parallelism. ......................................................................
Patch Set 11: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1398/11//COMMIT_MSG Commit Message: Line 9: Detailed list of changes include: Really appreciate this list! https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: Line 358: // Computes the location constraints based on user-configured parallism parameter. s/parallism/parallelism/ Line 366: int parallelism = parallelismHint <= 0 ? -2 * ncMap.size() : parallelismHint; What's the meaning of -2 here? https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 169: import org.apache.asterix.translator.TypeTranslator; There's something funny going on with the imports ... they are different for me .. https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java: Line 91: return testArgs; If there's another patchset we could just replace this method body with return LangExecutionUtil.buildTestsInXml(TestCaseContext.DEFAULT_REPEATED_TESTSUITE_XML_NAME); and remove the static import - but don't create a new patchset for this. https://asterix-gerrit.ics.uci.edu/#/c/1398/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java: Line 130: null); It seems that there could be some utility method the could determine the StructuralPropertiesVector based on the inputs, the context, and the classes of the partitioning properties that would make this more intuitive. But I'm not sure (and I'm not sure where to put it) - it's just a thought. -- To view, visit https://asterix-gerrit.ics.uci.edu/1398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If70faf52bed995c7098cc343f2fabd1b6c8d96e7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
