Yingyi Bu has posted comments on this change. Change subject: Supports flexible degree of parallelism. ......................................................................
Patch Set 11: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: Line 358: // Computes the location constraints based on user-configured parallism parameter. > s/parallism/parallelism/ Done Line 366: int parallelism = parallelismHint <= 0 ? -2 * ncMap.size() : parallelismHint; > What's the meaning of -2 here? A negative parallelism means to fully utilize all available cores. -2 ensures no NC gets a per-node parallelism number 0. Per-node parallelism 0 is valid as that means the partition is not involved in computation. Multiplying with -2 allows the same code to deal with negative and positive values. For example, if I have 4 partitions and the parallelism is 3, one partition won't be involved and will get the per-node parallelism number 0. If I have 4 partitions and the parallelism is -1, three partitions will get the per-node parallelism number 0, then at line 394, we need additional checks to see if this is really 0 or means sth. else. https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 169: import org.apache.asterix.translator.TypeTranslator; > There's something funny going on with the imports ... they are different fo Done https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java: Line 91: return testArgs; > If there's another patchset we could just replace this method body with Done https://asterix-gerrit.ics.uci.edu/#/c/1398/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java: Line 130: null); > It seems that there could be some utility method the could determine the St Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If70faf52bed995c7098cc343f2fabd1b6c8d96e7 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
