Till Westmann has posted comments on this change. Change subject: Generate License Files ......................................................................
Patch Set 4: (9 comments) Looks generally good. The generated LICENSE files look nice. I don't fully understand the Mojo, but it looks good and the seems to work well. I've got a few minor questions, and then there is the big known outage that the NOTICE is not generated yet. Do we generate the NOTICS as part of this change or as a separate change? https://asterix-gerrit.ics.uci.edu/#/c/1402/4//COMMIT_MSG Commit Message: Line 10: and 'asterix-yarn' binary assemblies Some more description of the content of the change? https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-installer/pom.xml File asterixdb/asterix-installer/pom.xml: Line 51: <goal>licensegen</goal> Do we have (do we need) some docs somewhere on how to use the new plugin? Line 110: --> Can we remove the commented element (or indent the comment)? https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java: Line 95: protected ArtifactMetadataSource artifactMetadataSource; The artifact* members seem to be deprecated and unused. Could/should we remove them? https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseSpec.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseSpec.java: Line 39: public LicenseSpec() { Do we need this constructor (e.g. for deserialization) or can we remove it? Line 75: else { "else" on the previous line? https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/freemarker/IndentDirective.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/freemarker/IndentDirective.java: Line 35: public class IndentDirective implements TemplateDirectiveModel { It seems that some lines in here are shorter than needed ... https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java: Line 35: public LicensedProjects() { Do we need this constructor (e.g. for deserialization) or can we remove it? https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java: Line 42: public Project() { Do we need this constructor (e.g. for deserialization) or can we remove it? -- To view, visit https://asterix-gerrit.ics.uci.edu/1402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0963a85cb2be47dbf6bfd8c7f6fec767ef32e7e2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
