Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1720 - Generate License Files ......................................................................
Patch Set 4: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-installer/pom.xml File asterixdb/asterix-installer/pom.xml: Line 51: <goal>licensegen</goal> > Do we have (do we need) some docs somewhere on how to use the new plugin? Will add issue to track this. https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java: Line 95: protected ArtifactMetadataSource artifactMetadataSource; > The artifact* members seem to be deprecated and unused. Could/should we rem Done https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseSpec.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseSpec.java: Line 39: public LicenseSpec() { > Do we need this constructor (e.g. for deserialization) or can we remove it? Done Line 75: else { > "else" on the previous line? Done https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/freemarker/IndentDirective.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/freemarker/IndentDirective.java: Line 35: public class IndentDirective implements TemplateDirectiveModel { > It seems that some lines in here are shorter than needed ... Done https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java: Line 35: public LicensedProjects() { > Do we need this constructor (e.g. for deserialization) or can we remove it? Done https://asterix-gerrit.ics.uci.edu/#/c/1402/4/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java: Line 42: public Project() { > Do we need this constructor (e.g. for deserialization) or can we remove it? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0963a85cb2be47dbf6bfd8c7f6fec767ef32e7e2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
