Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE] Parallel Build ......................................................................
Patch Set 1: (2 comments) If we catch TokenMgrException in each parser's parse() then we don't need to handle them in servlets https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: Line 291: } catch (Error e) { should catch TokenMgrException here instead of Error https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: Line 331: } catch (Error e) { should catch TokenMgrException here instead of Error -- To view, visit https://asterix-gerrit.ics.uci.edu/3197 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f9c8bdbd4d1c56f4258efc0c7698e18a81ab15b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
