Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE] Parallel Build ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java: Line 161: } catch (AsterixException | TokenMgrException pe) { > do we need to also catch aql/aqlplus TokenMgrException, as we did before? let's just catch AlgebricksException here. That's a superclass of both AsterixException and CompilationException https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java: Line 203: } catch (AsterixException | TokenMgrException pe) { > also catch aql/aqlplus TokenMgrException? let's just catch AlgebricksException here https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java: Line 128: || rootCause instanceof TokenMgrException)) { > same comment. what about aql/aqlplus? remove TokenMgrException. If we catch in in the parser then it'll reach here as CompilationException https://asterix-gerrit.ics.uci.edu/#/c/3197/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java: Line 145: } catch (AlgebricksException | HyracksException | TokenMgrException pe) { > same comment. aql/aqlplus? let's remove catching TokenMgrException. If we catch it in the parser then it'll reach here as CompilationException which is a subclass of AlgebricksException -- To view, visit https://asterix-gerrit.ics.uci.edu/3197 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f9c8bdbd4d1c56f4258efc0c7698e18a81ab15b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
