Hussain Towaileb has posted comments on this change. Change subject: [NO ISSUE][COMP] Optim rules comments + minor changes ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3201/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java: PS3, Line 66: IVariableTypeEnvironment env = context.getOutputTypeEnvironment(select); : if (env == null) { : env = select.computeOutputTypeEnvironment(context); : } > Is this just an optimization? or was there an issue here that we were facin Just for optimization. The InferTypesRule already computes the output type environment for all operators and stores it to the Algebricks context (if it gets executed before this rule). -- To view, visit https://asterix-gerrit.ics.uci.edu/3201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f5cb78125657ff2bb4658af40bfc9d9cbff184e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
