Hussain Towaileb has posted comments on this change. Change subject: [NO ISSUE][COMP] Optim rules comments + minor changes ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3201/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java: PS3, Line 66: IVariableTypeEnvironment env = context.getOutputTypeEnvironment(select); : if (env == null) { : env = select.computeOutputTypeEnvironment(context); : } > Just for optimization. // Edit: However, this might be invalid only if other rules make changes that "require" this rule to "recompute" its output type environment, but I haven't seen such a rule yet. I'm not an expert in optimization process yet, so your kind verification is appreciated. -- To view, visit https://asterix-gerrit.ics.uci.edu/3201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f5cb78125657ff2bb4658af40bfc9d9cbff184e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
