Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for record deep comparison
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3222/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java:

PS1, Line 402: getComplexFieldName
> You can use RuntimeRecordTypeInfo to get the type without deserializing the
I agree. We can do it in a follow up change.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3222
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8bfbb014b86295749e980d123b0d3edf079beb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-HasComments: Yes

Reply via email to