Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] add support for record deep comparison ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3222/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java: PS1, Line 402: getComplexFieldName > I agree. We can do it in a follow up change. I wonder if I can use the index directly (i and k here) and use IAType[] and String[] from ARecordType. It looks like ARecordVisitablePointable lays out the fields based on that, but I didn't do deep inspection. -- To view, visit https://asterix-gerrit.ics.uci.edu/3222 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e8bfbb014b86295749e980d123b0d3edf079beb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-HasComments: Yes
