Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget ......................................................................
Patch Set 60: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1056/60/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java: Line 310: if (freeSpace <= 0) { <=0 --> <0 ? Line 336: long expectedHashTableSizeDecrease = hashTableByteSizeForInMemTuples you can calculate the expectedHashTableSizeDecrease without inMemTupCount. Line 342: if (freeSpace > 0) { freeSpace > 0 --> freeSpace >= 0 ? Line 405: private int selectPartitionsToReload(long freeSpace, int pid, int inMemTupCount, long originalHashTableSize) { Why do you need "int inMemTupCount, long originalHashTableSize" ? It seems spilledTupleCount is sufficient for calculating the expectedHashTableSizeIncrease? Line 412: if (freeSpace > buildRFWriters[i].getFileSize() + expectedHashTableSizeIncrease) { > --> >= ? -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 60 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
