Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records ......................................................................
Patch Set 1: Code-Review+1 (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java: Line 52: * byte|int |byte |int |int |byte[] |int | | | |int |int |int| | | minor. I find previous description is easier to read. Was there anything wrong with it. Can we somehow keep it (may be in addition to the new one)? https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/RecordField.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/RecordField.java: Line 26: public final class RecordField { minor. add javadoc describing the purpose of this class. https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/SortedRecord.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/SortedRecord.java: Line 43: public final class SortedRecord { Can you add javadoc describing the purpose of this class? https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java: Line 61: // TODO: how come the item type in this instance is "null" not anymore. https://asterix-gerrit.ics.uci.edu/#/c/3247/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
