Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records ......................................................................
Patch Set 1: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java: PS1, Line 117: getTagOffset I think that we should also consider to inline a few of these methods, if they only have one consumer. Having well-named methods help to create self-describing code, but having too many methods can negate the benefits. https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java: Line 61: // TODO: how come the item type in this instance is "null" > not anymore. https://asterix-gerrit.ics.uci.edu/#/c/3247/ Indeed! -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes