Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java: Line 52: * Record { > minor. I find previous description is easier to read. Was there anything wr Done PS1, Line 117: int OPEN_CO > I think that we should also consider to inline a few of these methods, if t Done https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/RecordField.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/RecordField.java: Line 26: /** > minor. add javadoc describing the purpose of this class. Done https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/SortedRecord.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/SortedRecord.java: Line 43: /** > Can you add javadoc describing the purpose of this class? Done https://asterix-gerrit.ics.uci.edu/#/c/3280/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java: Line 61: TAGS_TO_TYPES.put(ATypeTag.MULTISET, AUnorderedListType.FULLY_OPEN_UNORDEREDLIST_TYPE); > not anymore. https://asterix-gerrit.ics.uci.edu/#/c/3247/ Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
