Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3280/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java: PS3, Line 29: private static final EnumMap<ATypeTag, IAType> TAGS_TO_TYPES = new EnumMap<>(ATypeTag.class); : : static { : TAGS_TO_TYPES.put(ATypeTag.TINYINT, BuiltinType.AINT8); : TAGS_TO_TYPES.put(ATypeTag.SMALLINT, BuiltinType.AINT16); : TAGS_TO_TYPES.put(ATypeTag.INTEGER, BuiltinType.AINT32); : TAGS_TO_TYPES.put(ATypeTag.BIGINT, BuiltinType.AINT64); : TAGS_TO_TYPES.put(ATypeTag.BINARY, BuiltinType.ABINARY); : TAGS_TO_TYPES.put(ATypeTag.BITARRAY, BuiltinType.ABITARRAY); : TAGS_TO_TYPES.put(ATypeTag.FLOAT, BuiltinType.AFLOAT); : TAGS_TO_TYPES.put(ATypeTag.DOUBLE, BuiltinType.ADOUBLE); : TAGS_TO_TYPES.put(ATypeTag.STRING, BuiltinType.ASTRING); : TAGS_TO_TYPES.put(ATypeTag.MISSING, BuiltinType.AMISSING); : TAGS_TO_TYPES.put(ATypeTag.NULL, BuiltinType.ANULL); : TAGS_TO_TYPES.put(ATypeTag.BOOLEAN, BuiltinType.ABOOLEAN); : TAGS_TO_TYPES.put(ATypeTag.DATETIME, BuiltinType.ADATETIME); : TAGS_TO_TYPES.put(ATypeTag.DATE, BuiltinType.ADATE); : TAGS_TO_TYPES.put(ATypeTag.TIME, BuiltinType.ATIME); : TAGS_TO_TYPES.put(ATypeTag.DURATION, BuiltinType.ADURATION); : TAGS_TO_TYPES.put(ATypeTag.POINT, BuiltinType.APOINT); : TAGS_TO_TYPES.put(ATypeTag.POINT3D, BuiltinType.APOINT3D); : TAGS_TO_TYPES.put(ATypeTag.TYPE, BuiltinType.ALL_TYPE); : TAGS_TO_TYPES.put(ATypeTag.ANY, BuiltinType.ANY); : TAGS_TO_TYPES.put(ATypeTag.LINE, BuiltinType.ALINE); : TAGS_TO_TYPES.put(ATypeTag.POLYGON, BuiltinType.APOLYGON); : TAGS_TO_TYPES.put(ATypeTag.CIRCLE, BuiltinType.ACIRCLE); : TAGS_TO_TYPES.put(ATypeTag.RECTANGLE, BuiltinType.ARECTANGLE); : TAGS_TO_TYPES.put(ATypeTag.INTERVAL, BuiltinType.AINTERVAL); : TAGS_TO_TYPES.put(ATypeTag.YEARMONTHDURATION, BuiltinType.AYEARMONTHDURATION); : TAGS_TO_TYPES.put(ATypeTag.DAYTIMEDURATION, BuiltinType.ADAYTIMEDURATION); : TAGS_TO_TYPES.put(ATypeTag.UUID, BuiltinType.AUUID); : TAGS_TO_TYPES.put(ATypeTag.OBJECT, RecordUtil.FULLY_OPEN_RECORD_TYPE); : TAGS_TO_TYPES.put(ATypeTag.MULTISET, AUnorderedListType.FULLY_OPEN_UNORDEREDLIST_TYPE); : TAGS_TO_TYPES.put(ATypeTag.ARRAY, AOrderedListType.FULL_OPEN_ORDEREDLIST_TYPE); : TAGS_TO_TYPES.put(ATypeTag.GEOMETRY, BuiltinType.AGEOMETRY); : } : : public static IAType getBuiltinTypeByTag(ATypeTag typeTag) throws HyracksDataException { : IAType type = TAGS_TO_TYPES.get(typeTag); : if (type != null) { : return type; : } > why? just curious... (enum map is certainly going to be less efficient tha This method is executed very often. I just thought it would be better than the big switch. I'll revert it. -- To view, visit https://asterix-gerrit.ics.uci.edu/3280 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
