Xikui Wang has posted comments on this change. Change subject: WIP - Load parser from classpath in ParserFactoryProvider ......................................................................
Patch Set 2: (1 comment) @Till I semi-copied your code to make this patch. I used one resource file to includes all existed parsers. I guess what you have in mind is to have one resource file for each parser. For these existed parsers, I imagine they all need resource file with same name, i.e. META-INF/services/org.apache.asterix.external.api.IDataParserFactory So I combined them into one. I am wondering how to make one resource file per each parser with existed parsers? btw, I found ServiceClassLoader while reading the documents. I guess it uses the same logic as your code. Right? https://asterix-gerrit.ics.uci.edu/#/c/1416/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java: Line 105: System.out.println(url); > MAJOR SonarQube violation: will remove this in next patch... -- To view, visit https://asterix-gerrit.ics.uci.edu/1416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ac039fe3daaf0636cf004289bd0c8a3229197a9 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
