Xikui Wang has posted comments on this change. Change subject: Load parser from classpath in ParserFactoryProvider ......................................................................
Patch Set 3: The JSON import is unnecessary here. I removed it in the updated patch. For the ServiceLoader part, I tried it out. One subtle difference is ServiceLoader load class as Instance instead of Class. Currently we are creating new instance whenever *ParserFactory is needed. As we are dealing with factory class, I thought load as instance and use it forever would work. But due to some configuration issue(I guess), some parser cases failed. To avoid potential hazard here, I kept the solution in last one... I want to integrate the CAPParser into the bad branch as an extension for the next step, but the how is BAD integrated with AsterixDB is not that clear to me... Do you know who is the best person to ask? -- To view, visit https://asterix-gerrit.ics.uci.edu/1416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ac039fe3daaf0636cf004289bd0c8a3229197a9 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: No
