Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 )
Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java@121 PS2, Line 121: // i think UNION shouldn't be allowed. the actual type could be closed array or record. ANY would fail. I agree about UNION. would be great if we could investigate and prevent this. -- To view, visit https://asterix-gerrit.ics.uci.edu/3336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09 Gerrit-Change-Number: 3336 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 19:08:33 +0000 Gerrit-HasComments: Yes
