Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 )
Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider ...................................................................... Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryComparatorFactoryProvider.java@97 PS2, Line 97: // TODO(ali): Good question. File an issues and/or ask somebody who relies on lowercase comparisons? https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/3336/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/TypeTraitProvider.java@36 PS2, Line 36: TWELVE_BYTES Stick with the naming convention? -- To view, visit https://asterix-gerrit.ics.uci.edu/3336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37767a3f3d1e3b29597d2a4998c0b60005cadb09 Gerrit-Change-Number: 3336 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Tue, 16 Apr 2019 19:53:44 +0000 Gerrit-HasComments: Yes