Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3409 )
Change subject: [NO ISSUE][FUN] Bitwise - adjust type "any" behavior ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3409/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java: https://asterix-gerrit.ics.uci.edu/#/c/3409/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java@67 PS1, Line 67: boolean isReturnNullable = false; > I mean that the case of argument being ANY is supposed to be handled by Abs You're right, seems the AbstractResultTypeComputer handles both the case of missing and null, and for any, it wraps the output making it missable and nullable. (I didn't know about the last part) In that case, I did a minor change, I moved the type any to be of certain result (not nullable anymore), since if the type is any, the AbstractResultTypeComputer will wrap it and make it nullable and missable. -- To view, visit https://asterix-gerrit.ics.uci.edu/3409 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93e002531812ac26fe70e573db1467ea52b9920a Gerrit-Change-Number: 3409 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Comment-Date: Wed, 29 May 2019 13:38:26 +0000 Gerrit-HasComments: Yes
