Hussain Towaileb has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3409 )
Change subject: [NO ISSUE][FUN] Bitwise - adjust type "any" behavior ...................................................................... [NO ISSUE][FUN] Bitwise - adjust type "any" behavior - user model changes: no - storage format changes: no - interface changes: no Details: - AbstractResultTypeComputer is handling wrapping the output in case of any, no need to return a nullable in case of any, just return the type we're expecting. Change-Id: I93e002531812ac26fe70e573db1467ea52b9920a Reviewed-on: https://asterix-gerrit.ics.uci.edu/3409 Contrib: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Dmitry Lychagin <[email protected]> --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitValuePositionFlagTypeComputer.java 2 files changed, 3 insertions(+), 5 deletions(-) Approvals: Jenkins: Verified; ; Verified Anon. E. Moose (1000171): Dmitry Lychagin: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java index 3117fba..a18253a 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java @@ -73,10 +73,10 @@ case SMALLINT: case INTEGER: case BIGINT: + case ANY: continue; case FLOAT: case DOUBLE: - case ANY: isReturnNullable = true; continue; default: diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitValuePositionFlagTypeComputer.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitValuePositionFlagTypeComputer.java index 3e3256a..1c5a746 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitValuePositionFlagTypeComputer.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitValuePositionFlagTypeComputer.java @@ -93,10 +93,10 @@ case SMALLINT: case INTEGER: case BIGINT: + case ANY: break; case FLOAT: case DOUBLE: - case ANY: isReturnNullable = true; break; default: @@ -109,10 +109,10 @@ case SMALLINT: case INTEGER: case BIGINT: + case ANY: break; case FLOAT: case DOUBLE: - case ANY: isReturnNullable = true; break; case ARRAY: @@ -148,9 +148,7 @@ IAType thirdArgument = strippedInputTypes[2]; switch (thirdArgument.getTypeTag()) { case BOOLEAN: - break; case ANY: - isReturnNullable = true; break; default: return BuiltinType.ANULL; -- To view, visit https://asterix-gerrit.ics.uci.edu/3409 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I93e002531812ac26fe70e573db1467ea52b9920a Gerrit-Change-Number: 3409 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]>
