Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3437 )
Change subject: [ASTERIXDB-2593][FUN] TPC-DS always parallelize + gen all tables ...................................................................... Patch Set 8: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3437/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSAllTablesDataGeneratorDatasource.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSAllTablesDataGeneratorDatasource.java: https://asterix-gerrit.ics.uci.edu/#/c/3437/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSAllTablesDataGeneratorDatasource.java@37 PS7, Line 37: private final double scalingFactor; > tableName is always 'null' here? why keep this field? Done. https://asterix-gerrit.ics.uci.edu/#/c/3437/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java: https://asterix-gerrit.ics.uci.edu/#/c/3437/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java@192 PS7, Line 192: // Return parent row > I'd move these 3 lines (192-195) to the constructor. This method assigns th You're right, that makes sense. Since the data is all correlated, and that's the only piece of code that uses the session, I just moved it all to the constructor and removed unnecessary member variables and converted them to local variables. https://asterix-gerrit.ics.uci.edu/#/c/3437/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java@217 PS7, Line 217: if (matchedTables.size() != 1) { > can we assign this field ('gemerateAllTables') in the constructor? (so this Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3437 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff199b0c533d22bcae1caf5057788b257ba4e486 Gerrit-Change-Number: 3437 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2019 15:42:02 +0000 Gerrit-HasComments: Yes
