Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3437 )
Change subject: [ASTERIXDB-2593][FUN] TPC-DS always parallelize + gen all tables ...................................................................... Patch Set 8: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3437/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java: https://asterix-gerrit.ics.uci.edu/#/c/3437/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSDataGeneratorReader.java@165 PS8, Line 165: String parentRow = builder.toString(); It'd be nice at some point to see whether we avoid string copying here. StringBuilder.toString() makes a copy of the content. Then String.toCharArray() does another copy. Then CharArray.append() makes a third copy. We could introduce CharArrayRecord.append(java.lang.CharSequence) method, then see if we could append StringBuilder directly (because StringBuilder implements CharSequence). So only one copy would be done by CharArrayRecord.append() -- To view, visit https://asterix-gerrit.ics.uci.edu/3437 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff199b0c533d22bcae1caf5057788b257ba4e486 Gerrit-Change-Number: 3437 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2019 18:17:27 +0000 Gerrit-HasComments: Yes
