>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565 )
Change subject: [NO ISSUE] UDF API improvements ...................................................................... Patch Set 29: (7 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java@78 PS29, Line 78: protected final IParserFactory parserFactory = new SqlppParserFactory(); use compilationProvider.getParserFactory() instead. NCUdfApiServlet has access to compilationProvider https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java@94 PS29, Line 94: private LibraryUploadData(List<InterfaceHttpData> dataverse, MixedAttribute name, MixedAttribute type, The design of these 4 constructors is confusing. The 'op' field is hard-coded in each, so it's not clear which combination of parameters corresponds to each op kind. Can we have a single constructor instead that'd take op and all parameters and let libraryCreation/Deletion methods do the actual work needed. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java@118 PS29, Line 118: this.replaceIfExists = replaceIfExists; I'm confused. replaceIfExists has no meaning for LibraryOperation.DELETE. why are we passing in via constructor parameter here? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java@138 PS29, Line 138: this.replaceIfExists = replaceIfExists; I'm confused. replaceIfExists has no meaning for LibraryOperation.DELETE. why are we passing in via constructor parameter here? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java@1300 PS29, Line 1300: String[] dataverse = command[1].split(":"); you could use a dataverse display form here as well instead of creating your own encoding. instantiate parser via SqlppParserFactory.createParser() here and call parseMultipartIdentifier() on it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java@1313 PS29, Line 1313: dataverse = command[1].split(":"); same comment as above regarding using dataverse's display form here. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/29/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_sqlpp.xml@67 PS29, Line 67: <expected-error>ASX3042: UDF of kind badType not supported</expected-error> we need to improve this error message. Unsupported function language: ..., or something like that. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: Ib6e6ce7debc9c2e07d24163542c1f98886792165 Gerrit-Change-Number: 9565 Gerrit-PatchSet: 29 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 10 Mar 2021 02:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
