>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565 )
Change subject: [NO ISSUE] UDF API improvements ...................................................................... Patch Set 32: (3 comments) partial review (only ExternalLibraryManager) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/32/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/32/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java@244 PS32, Line 244: getLibraryListing how do we handle pre-backwards-compatible dataverses that potentially start with StoragePathUtil.DATAVERSE_CONTINUATION_MARKER? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/32/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java@259 PS32, Line 259: charAt codePointAt https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565/32/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalLibraryManager.java@274 PS32, Line 274: charAt codePointAt... it might be good to add some 'isDataverseContinuationSegment(String|Path)' or something helper method(s) to StoragePathUtil and call that for all the places we do this -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9565 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: Ib6e6ce7debc9c2e07d24163542c1f98886792165 Gerrit-Change-Number: 9565 Gerrit-PatchSet: 32 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Sat, 13 Mar 2021 15:07:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
