>From Wael Alkowaileet <[email protected]>: Wael Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483 )
Change subject: [ASTERIXDB-2935] Azure Blob: add support to active directory auth ...................................................................... Patch Set 9: Code-Review+1 (2 comments) I reviewed the external data part. The comments could be addressed in a followup change. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java@1166 PS9, Line 1166: secret minor: probably "certificate" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java@1230 PS9, Line 1230: param.get() minor: the user may remove the params one by one as the message only complains about one of them. Can we say all of them should not be present? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I143eddd4be19e769d0bc97184d26f8a05b908e39 Gerrit-Change-Number: 12483 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 21:31:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
