>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483 )
Change subject: [ASTERIXDB-2935] Azure Blob: add support to active directory auth ...................................................................... Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java@1166 PS9, Line 1166: secret > minor: probably "certificate" Indeed you're right, will fix in a follow-up change. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483/9/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java@1230 PS9, Line 1230: param.get() > minor: the user may remove the params one by one as the message only > complains about one of them. […] This will require using an error message that expects an array of params, I believe we do support that, will check and fix in a follow-up change, good call. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12483 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I143eddd4be19e769d0bc97184d26f8a05b908e39 Gerrit-Change-Number: 12483 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Thu, 12 Aug 2021 12:39:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wael Alkowaileet <[email protected]> Gerrit-MessageType: comment
