abdullah alamoudi has posted comments on this change. Change subject: Introduce IComponentProvider ......................................................................
Patch Set 14: (64 comments) https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExtension.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExtension.java: Line 59 > Why this static method is put in this interface? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java: Line 77: > renaming? retainNull -> retainMissing Done https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java: Line 169: * a map of key fields that will be validated > Code style? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java: Line 75: } > code style? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: PS14, Line 216: ( > analyzeJobCommit(winnerJobSet, logRecord); Done PS14, Line 216: ( > Reduce side effects: Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java: PS14, Line 174: Thread > When can the while condition return false? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/ComponentProvider.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/ComponentProvider.java: PS14, Line 36: ComponentProvider > ComponentProvider --> StorageComponentProvider Done PS14, Line 36: IComponentProvider > IComponentProvider --> IStorageComponentProvider Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/DataverseUtils.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/util/DataverseUtils.java: PS14, Line 19: util > util -> utils Done PS14, Line 31: DataverseUtils > DataverseUtil -> DataverseUtil Done PS14, Line 39: splitAndConstraints > splitAndConstraints Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/ExtensionUtils.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/util/ExtensionUtils.java: PS14, Line 35: ExtensionUtils > ExtensionUtils -> ExtensionUtil Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorApiLetTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorApiLetTest.java: PS14, Line 172: ComponentProvider > use null here since the component provider shouldn't be reached from the fi will throw a NPE in the constructor. https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java: PS14, Line 81: storageManager > storageManager --> storageComponentProvider Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAppRuntimeContext.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAppRuntimeContext.java: PS14, Line 116: getComponentProvider > getComponentProvider() --> getStorageComponentProvider() Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IComponentProvider.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IComponentProvider.java: PS14, Line 30: runtime > runtime components Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java: PS14, Line 45: getRuntimeComponentProvider > getRuntimeComponentProvider --> getStorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMTreeInsertDeleteOperatorDescriptor.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMTreeInsertDeleteOperatorDescriptor.java: PS14, Line 50: LSMTreeInsertDeleteOperatorDescriptor > runtimeComponentProvider --> storageManager Done PS14, Line 50: LSMTreeInsertDeleteOperatorDescriptor > runtimeComponentProvider --> storageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionSubsystem.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionSubsystem.java: PS14, Line 25: level > responsible -> is responsible Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/util/ConfigUtil.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/util/ConfigUtil.java: PS14, Line 19: util > util -> utils Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/IndexInfoOperatorDescriptor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/IndexInfoOperatorDescriptor.java: PS14, Line 72: getRuntimeComponentProvider > getRuntimeComponentProvider --> getStorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: PS14, Line 157: componentProvider > storageComponentProvider Done PS14, Line 1100: jobId > remove the useless jobId.getId() ? Done PS14, Line 1692: getRuntimeComponentProvider > getRuntimeComponentProvider --> getStorageComponentProvider Done PS14, Line 2051: splitAndConstraints > splitAndConstraints --> getSplitProviderAndConstraints Done PS14, Line 2117: getComponentProvider > getComponentProvider -- > getStorageComponentProvider Done https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java: Line 428: * if the factory could not be created for the index/dataset combination > "Create the index dataflow helper factory" Done Line 438: return LSMRTreeIOOperationCallbackFactory.INSTANCE; > Code format doesn't seem to follow the code style. Done Line 473: * @throws AlgebricksException > Document the method, parameters, return and throws. Done Line 476: public ISearchOperationCallbackFactory getSearchCallbackFactory(IComponentProvider storageComponentProvider, > ioOperationCallbackFactory--> getIoOperatortionCallbackFactory. Done Line 498: * the index > Document the method, parameters, return and throws. Done Line 502: * the operation performed for this callback > indexOperationTrackerProvider --> getIndexOperationTrackerProvider Done Line 510: public IModificationOperationCallbackFactory getModificationCallbackFactory(IComponentProvider componentProvider, > Document the method, parameters, return and throws. Done Line 516: return op == IndexOperation.UPSERT > searchBacllbackFactory --> getSearchCallbackFactory Done Line 537: try { > Document the method, parameters, return and throws. Done Line 543: } > modificationCallbackFactory --> getModificationCallbackFactory Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/DatasetLock.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/DatasetLock.java: PS14, Line 19: util > util -> utils Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/DatasetUtils.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/DatasetUtils.java: PS14, Line 84: DatasetUtils > DatasetUtils -> DatasetUtil Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/IndexUtils.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/IndexUtils.java: PS14, Line 19: util > util -> utils Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/KeyFieldTypeUtils.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/KeyFieldTypeUtils.java: Line 35: public class KeyFieldTypeUtils { > fix this? Done PS14, Line 35: KeyFieldTypeUtils > KeyFieldTypeUtils -> KeyFieldUtil Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/MetadataLockManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/MetadataLockManager.java: Line 30: public static MetadataLockManager INSTANCE = new MetadataLockManager(); > Fix this? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/MetadataUtils.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/MetadataUtils.java: PS14, Line 21: MetadataUtils > MetadataUtils -> MetadataUtil Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/TypeUtils.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/util/TypeUtils.java: PS14, Line 40: TypeUtils > TypeUtils --> TypeUtil Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMTreeUpsertOperatorDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMTreeUpsertOperatorDescriptor.java: PS14, Line 61: iPageManagerFactory) > iPageManagerFactory -> pageManagerFactory Done https://asterix-gerrit.ics.uci.edu/#/c/1451/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AppContextInfo.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AppContextInfo.java: PS4, Line 181: aryManager getLibraryMan > avoid the setter method, and instead, passing that through the constructor. Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeclient/src/main/java/org/apache/hyracks/examples/btree/client/SecondaryIndexSearchExample.java File hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreeclient/src/main/java/org/apache/hyracks/examples/btree/client/SecondaryIndexSearchExample.java: PS14, Line 101: RuntimeContextComponentProvider > RuntimeContextComponentProvider -> StorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/src/main/java/org/apache/hyracks/examples/btree/helper/RuntimeContextComponentProvider.java File hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/src/main/java/org/apache/hyracks/examples/btree/helper/RuntimeContextComponentProvider.java: PS14, Line 29: RuntimeContextComponentProvider > RuntimeContextComponentProvider -> StorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/btree/AbstractBTreeOperatorTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/btree/AbstractBTreeOperatorTest.java: PS14, Line 74: TestRuntimeComponentProvide > TestRuntimeComponentProvider -> TestStorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeDataflowHelper.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeDataflowHelper.java: PS14, Line 48: getRuntimeComponentProvider > getRuntimeComponentProvider -> getStorageComponentProvider Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/AbstractIndexOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/AbstractIndexOperatorDescriptor.java: PS14, Line 41: runtimeComponentProvider; > runtimeComponentProvider -> storageManager Done PS14, Line 64: runtimeComponentProvider > runtimeComponentProvider -> storageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/AbstractTreeIndexOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/AbstractTreeIndexOperatorDescriptor.java: PS14, Line 45: runtimeComponentProvider > runtimeComponentProvider -> storageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IIndexOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IIndexOperatorDescriptor.java: PS14, Line 37: getRuntimeComponentProvider > getRuntimeComponentProvider -> getStorageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/dataflow/LSMTreeIndexCompactOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/dataflow/LSMTreeIndexCompactOperatorDescriptor.java: PS14, Line 44: runtimeComponentProvider > runtimeComponentProvider -> storageManager Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/dataflow/RTreeDataflowHelper.java File hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/dataflow/RTreeDataflowHelper.java: PS14, Line 52: etRuntimeComponentProvider() > getRuntimeComponentProvider() -> getStorageManager() Done PS14, Line 53: getRuntimeComponentProvider() > getRuntimeComponentProvider() -> getStorageManager() Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IStorageManager.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IStorageManager.java: PS14, Line 36: disk > disk buffer cache Done PS14, Line 43: root > root? Done PS14, Line 50: root > root? Done PS14, Line 57: root > root? Done https://asterix-gerrit.ics.uci.edu/#/c/1451/14/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestRuntimeComponentProvider.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestRuntimeComponentProvider.java: PS14, Line 28: TestRuntimeComponentProvider > TestRuntimeComponentProvider -> TestStorageManager Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1451 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86750cdb2436c713f6598e54d4aaaf23d9f7bbf Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
