Yingyi Bu has posted comments on this change. Change subject: Introduce IStorageComponentProvider ......................................................................
Patch Set 16: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/1451/16//COMMIT_MSG Commit Message: PS16, Line 7: IStorageComponentProvider Itemize the changes, e.g., -- factor out ... into Dataset; -- ... IStorageComponentProvider, which ... https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java: PS16, Line 33: TransactionUtils TransactionUtils -> TranslationUtil https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java: Line 197: statementExecutorFactory.create(aqlStatements, sessionConfig, compilationProvider, componentProvider); > MAJOR SonarQube violation: Format? https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java: PS16, Line 28: IStorageManagerInterface IStorageManagerInterface -> IStorageComponentProvider PS16, Line 29: implementation add "IGlobalRecoveryManager" and "ILibraryManager". PS16, Line 43: IRuntimeComponentProvider IRuntimeComponentProvider -> IStorageComponentProvider https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtils.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtils.java: PS16, Line 30: TransactionUtils TransactionUtils -> TransactionUtil https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java: Line 194: .getSplitProviderAndConstraints(index.getDataverseName(), index.getDatasetName(), index.getIndexName(), dataset > MAJOR SonarQube violation: format? https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java: PS16, Line 392: static Move static methods to a util class. Why they are related to type? https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AppContextInfo.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AppContextInfo.java: PS16, Line 210: JobSpecification Move the static method into a Util class? Like the previous one, JobSpecificationUtil. https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMInvertedIndexLocalResourceMetadata.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMInvertedIndexLocalResourceMetadata.java: PS16, Line 85: LocalResource format? https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMRTreeLocalResourceMetadata.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMRTreeLocalResourceMetadata.java: PS16, Line 86: LocalResource format? https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: PS16, Line 49: replication alphabetically ordered? -- To view, visit https://asterix-gerrit.ics.uci.edu/1451 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86750cdb2436c713f6598e54d4aaaf23d9f7bbf Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
