>From Murtadha Hubail <[email protected]>: Attention is currently required from: Wail Alkowaileet. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225 )
Change subject: [ASTERIXDB-3026][STO][HYR] Part 2: Introduce LSMColumnBTree ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeBulkloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225/comment/c1670a5a_98a266a1 PS4, Line 82: tupleCount == 0 I'm assuming there will be a logic to handle multipage values when writing to the temporary buffers and therefore it is fine to assume that we will be able to write at least one tuple if we don't have any tuples yet. Is that the case? File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225/comment/92aa6e0b_d1aef461 PS4, Line 52: getParameter I don't think this is used yet. I'm assuming you will need it in a next patch. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icbb7346b84cabd3b5d30f4d3e1e24feae7880b9a Gerrit-Change-Number: 17225 Gerrit-PatchSet: 4 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
