>From Wail Alkowaileet <[email protected]>: Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225 )
Change subject: [ASTERIXDB-3026][STO][HYR] Part 2: Introduce LSMColumnBTree ...................................................................... Patch Set 4: (2 comments) File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/btree/ColumnBTreeBulkloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225/comment/114ef98c_5afb17d3 PS4, Line 82: tupleCount == 0 > I'm assuming there will be a logic to handle multipage values when writing to > the temporary buffers […] This check here is mainly for the first insert of a tuple on an empty "mega leaf node" where both lowKey and highKey (i.e., splitKey) are not known/initialized yet. The purpose of the check is guard agains accessing both keys (low/high) in line 94. But your assumption is correct, a page must have at least one tuple. File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225/comment/c2899c6e_639b121e PS4, Line 52: getParameter > I don't think this is used yet. I'm assuming you will need it in a next patch. Correct -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17225 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icbb7346b84cabd3b5d30f4d3e1e24feae7880b9a Gerrit-Change-Number: 17225 Gerrit-PatchSet: 4 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 14 Sep 2022 16:26:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
