>From Ian Maxon <[email protected]>:

Attention is currently required from: Wail Alkowaileet.
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924 )

Change subject: [ASTERIXDB-3054][RT] Add more profiling info
......................................................................


Patch Set 28: Code-Review+1

(3 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924/comment/abc80b8e_739216e5
PS26, Line 9:   - min, max, avg tuple sizes
            :   - compile time
            :   - show job creation,start,end, and queued time in profile
            :   - tuple counts per operator
            :   - spilling and level info for HHJ
            :   - enable most SQLPPExecutionTests w/ profiling on
> I think it is more than HHJ. […]
Ack


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalScanOperatorDescriptor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924/comment/fcb60a81_5ff70ee1
PS26, Line 70: new NoOpOperatorStats
> Use the singleton instance
Done


File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/StreamStatsOperatorDescriptor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924/comment/4a37b6da_afa54fdb
PS26, Line 70: getStatsCollector
> Can this be null?
in tests yes so it should be guarded to be safe



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Icf2a8f66f39e39eb6a39506c9f385d603976a87e
Gerrit-Change-Number: 15924
Gerrit-PatchSet: 28
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Vijay Sarathy <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-Comment-Date: Wed, 05 Oct 2022 22:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
Gerrit-MessageType: comment

Reply via email to