>From Ian Maxon <[email protected]>: Attention is currently required from: Wail Alkowaileet. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924 )
Change subject: [ASTERIXDB-3054][RT] Add more profiling info ...................................................................... Patch Set 28: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalScanOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924/comment/69e2681b_9f6d6dad PS21, Line 81: stats.getInputTupleCounter().update(adapter.getProcessedTuples()); > should probably use the NoOpStats here Ack File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/StreamStatsOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924/comment/8e9fdc25_2692c985 PS26, Line 96: if (statsCollector != null) { > Can this be null? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15924 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icf2a8f66f39e39eb6a39506c9f385d603976a87e Gerrit-Change-Number: 15924 Gerrit-PatchSet: 28 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 23:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
