>From Murtadha Hubail <[email protected]>: Attention is currently required from: Wail Alkowaileet. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437 )
Change subject: [ASTERIXDB-3142] Add columnar format tests ...................................................................... Patch Set 2: (1 comment) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437/comment/df8a04c7_6045ec01 PS2, Line 18: storage-format Sorry, my comment in the previous patch wasn't clear enough. I think thinking that since this is an object and we might be able to use it for any storage related things in the future, we should change it to only say "storage". Something sounds a bit off about using "storage-format" then a field called "format" inside the object. However, if you feel like we should limit the "storage-format" object to only storage format related parameters, then this should be okay too. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3eb20140b25a0439342c2ed2430a6de4c8fdb0b0 Gerrit-Change-Number: 17437 Gerrit-PatchSet: 2 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Sat, 18 Mar 2023 12:49:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
