>From Wail Alkowaileet <[email protected]>:

Attention is currently required from: Murtadha Hubail.
Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437 )

Change subject: [ASTERIXDB-3142] Add columnar format tests
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437/comment/a804ef8e_eac3df7e
PS2, Line 18: storage-format
> Sorry, my comment in the previous patch wasn't clear enough. […]
I don't have strong feelings toward any of the two (i.e., 'storage-format' and 
'storage'). However, we also have 'storage-block-compression' which is an 
additional storage-related configuration that will be living outside the newly 
proposed field 'storage'. That's why I wanted to be more specific by naming it 
'storage-format'.

Also, the columnar format has two additional (also optional) parameters, namely:
- max-tuple-count: which determines the maximum number of tuples stored in a 
mega leaf node of the BTree
- free-space-tolerance: a percentage that determines how much free space will 
be tolerated to avoid column splitting between two physical pages.

So, these two are format related parameters.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17437
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3eb20140b25a0439342c2ed2430a6de4c8fdb0b0
Gerrit-Change-Number: 17437
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Comment-Date: Sat, 18 Mar 2023 14:41:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail <[email protected]>
Gerrit-MessageType: comment

Reply via email to