>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ian Maxon, Till Westmann, Ali Alsuliman, Ritik Raj. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 )
Change subject: [ASTERIXDB-3155][SQL] Supporting escape backticks and singleQuote in SQL++ ...................................................................... Patch Set 7: (8 comments) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/60891648_10572eb5 PS7, Line 262: It will not pass through lexer , but adding IllegalStateException Con no space before comma. For example, lexer, but .. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/08ec5212_a67ebaae PS7, Line 270: if (cray[0] != cray[cray.length - 1]) { : throw new IllegalStateException("Should have been caught by the lexer"); : } not a required check since this function is called for quoted strings or string literals. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/4544c508_b7044579 PS7, Line 308: if (cray[0] == '\'' && c == '\'') { // if single quoted, allow '' as an escaped single quote "Hello''World" should keep both the single quotes. Also select 'Hello''World' already works. Please check these cases, and add test cases for them as well. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/32b19a6a_32e870a1 PS7, Line 318: else if (cray[0] == c) what if c is cray[cray.length-1] and cray[0] is double quotes.? File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/dfced654_809894ed PS7, Line 5760: EscapeBackTick To match other token naming, maybe rename to EscapeBtickWithBslash. Update it at other places too. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/03e64d5c_19f26f5b PS7, Line 5761: EscapeBackTickBackTick Rename to EscapeBtickWithBtick. Update it at other places too. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/adb1ed2e_e284df3e PS7, Line 5770: | <EscapeBackTick> : | <EscapeBackTickBackTick> Is this backtick escaping needed here as this is a string literal starting with "? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/990dda0b_47579a2e PS7, Line 5782: | <EscapeBackTick> : | <EscapeBackTickBackTick> Is this backtick escaping needed here as this is a string literal starting with '? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d9069c6aaa1365545f7e0ca728be6ea2ca4641d Gerrit-Change-Number: 17450 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Wed, 29 Mar 2023 20:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
